Fix race between two concurrent critnib_remove() calls - #1383
Closed
ldorau wants to merge 1 commit into
Closed
Conversation
ldorau
force-pushed
the
Fix_race_between_two_concurrent_critnib_remove_calls
branch
from
June 23, 2025 14:12
b142203 to
76a3c1c
Compare
Fix race between two concurrent critnib_remove() calls. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
force-pushed
the
Fix_race_between_two_concurrent_critnib_remove_calls
branch
from
June 24, 2025 09:57
76a3c1c to
05bdf0d
Compare
lplewa
reviewed
Jun 24, 2025
| if (c->cb_free_leaf && value) { | ||
| void *expected = value; | ||
| void *desired = NULL; | ||
| if (utils_compare_exchange_u64((uint64_t *)&k->value, |
Contributor
There was a problem hiding this comment.
add ptr version of utils_compare_exchange (note: there is special function on windows for it)
ldorau
marked this pull request as draft
June 24, 2025 10:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix race between two concurrent critnib_remove() calls.
It fixes a fail like in:
https://github.com/oneapi-src/unified-memory-framework/actions/runs/15815018773/job/44572264620
caused by two concurrent
umfMemoryTrackerRemoveIpcSegment()calls.Checklist